feat(@angular-devkit/build-angular): Add progress reporters for webpack builds#13405
feat(@angular-devkit/build-angular): Add progress reporters for webpack builds#13405GingerGeek wants to merge 1 commit into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
GingerGeek
force-pushed
the
build-progress-reporters
branch
2 times, most recently
from
bca7998 to
8341a89
Compare
…ck builds Add progress reporters for webpack builds. Previously only the default webpack progress handler was used. The default handler did not display well in all CI environments as it attempted to use the same console line for all progress updates. Add simple progress report, logging on new lines each time the build stage or build percentage changes. Add verbose progress report, logging on new lines on every progress update with additional data provided by webpack. Change default behaviour on non TTY consoles to use the simple progress report over the current behaviour of no progress reporting, this gives visibility over the status of build.
GingerGeek
force-pushed
the
build-progress-reporters
branch
from
8341a89 to
6294fb9
Compare
|
@googlebot CLA should be sorted! |
|
@GingerGeek this is a large change and we should discuss further if we can merge it. For such big changes, I'd recommend you to first open an issue so we can discuss if this is in the scope of the project. |
alexeagle
added
the
needs: discussion
filipesilva
removed
the
needs: discussion
|
There are quite a few merge conflicts here and this PR has been open since January. Let's close it for now and keep the discussion in #13426. When we agree how to proceed forward, we can go with another PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Previews
default-webpackDelegate to default handler within ProgressPlugin in webpack (existing behaviour)
simple-colorLogging on new lines each time the build stage or build percentage changes (w/ colour)
verbose-colorLogging on new lines on every progress update with additional data provided by webpack (w colour)
simple-plainLogging on new lines each time the build stage or build percentage changes (w/o colour)
verbose-plainLogging on new lines on every progress update with additional data provided by webpack (w/o colour)
